-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support nif module reload #222
Merged
Merged
+922
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
force-pushed
the
dev/william/nif-module-reload
branch
from
October 6, 2023 14:02
390315e
to
14be7c9
Compare
qzhuyan
force-pushed
the
dev/william/nif-module-reload
branch
from
October 6, 2023 20:18
14be7c9
to
efe9d81
Compare
Pull Request Test Coverage Report for Build 6482531202
💛 - Coveralls |
qzhuyan
force-pushed
the
dev/william/nif-module-reload
branch
4 times, most recently
from
October 10, 2023 07:26
b232e5a
to
97f6167
Compare
qzhuyan
commented
Oct 10, 2023
qzhuyan
commented
Oct 10, 2023
qzhuyan
commented
Oct 10, 2023
qzhuyan
force-pushed
the
dev/william/nif-module-reload
branch
from
October 10, 2023 11:58
0d56b14
to
11067a8
Compare
qzhuyan
commented
Oct 10, 2023
qzhuyan
force-pushed
the
dev/william/nif-module-reload
branch
2 times, most recently
from
October 10, 2023 15:05
b6886f0
to
3e28c91
Compare
ieQu1
reviewed
Oct 10, 2023
msquic API Doc: StreamOpen.md So, apps that rely on that event to trigger clean up of the stream **must** handle the case where [StreamStart](StreamStart.md) is either not ever called or fails and clean up directly.
qzhuyan
force-pushed
the
dev/william/nif-module-reload
branch
from
October 10, 2023 18:53
662873e
to
93686be
Compare
qzhuyan
force-pushed
the
dev/william/nif-module-reload
branch
from
October 11, 2023 12:31
055a455
to
dc72431
Compare
thalesmg
reviewed
Oct 11, 2023
It is just nice to call it to avoid unnecessary return '{error, invalid_parameter}'
thalesmg
previously approved these changes
Oct 11, 2023
thalesmg
approved these changes
Oct 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
code:purge(quicer_nif)
andcode:delete(quicer_nif)
work properly so that the msquic library could be unloaded from process memory. This is precondition that we could support hot upgrade, unload the old version of code.There are many changes in test suite to ensure resources are cleaned in each testcase run because it is risky to keep unlean resources running such as calling callbacks with dangling pointer. To prevent that the call to the unload module will wait forever until all resources (msquic handles) are closed.
I also did some major changes to close the msquic handles much earlier when the msquic handles are safe to be closed.
In the old impl. handles are closed only when deallocating nif resources but now we do it much earlier with the cost of using mutex.
Followups:
[] Ensure all APIs are thread safe since we 'close the handle earlier'.
[]
{error, invalid_paramter}
could be avoided if we check if NULL before passing the handle to msquic API.[] release script needs to pick versioned so files and lttng build files as well.